Re: [PATCH v4] quickfetch(): Prevent overflow of the rev-list command line
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:47:02
Subsystem:
the rest · Maintainer:
Linus Torvalds
With this fixup the patch is good, I think. -- Hannes
diff --git a/builtin-fetch.c b/builtin-fetch.c
index 34ba878..7547631 100644
--- a/builtin-fetch.c
+++ b/builtin-fetch.c@@ -446,14 +446,16 @@ static int quickfetch(struct ref *ref_map) return err; } - /* If rev-list --stdin encounters an unknown commit, it terminates, - * which will cause SIGPIPE in the write loop below. */ + /* + * If rev-list --stdin encounters an unknown commit, it terminates, + * which would cause SIGPIPE in the write loop below. + */ sigchain_push(SIGPIPE, SIG_IGN); for (ref = ref_map; ref; ref = ref->next) { if (write_in_full(revlist.in, sha1_to_hex(ref->old_sha1), 40) < 0 || write_in_full(revlist.in, "\n", 1) < 0) { - if (err != EPIPE && err != EINVAL) + if (errno != EPIPE && errno != EINVAL) error("failed write to rev-list: %s", strerror(errno)); err = -1; break;