Re: [PATCH] quickfetch(): Prevent overflow of the rev-list command line

On Thursday 09 July 2009, Johannes Sixt wrote:

Johan Herland schrieb:

quoted

Does anybody with Windows/MSYS experience know how this scenario
(write() to a terminated process, followed by close()) would play out
in msysGit?

The first write() sometimes fails with EPIPE, otherwise it fails with
EINVAL. All subsequent write()s fail with EINVAL. The setting of SIGPIPE
is irrelevant because it is unknown to Windows.

There's precedent already in write_or_die.c. You should not write the
error message for both EPIPE and EINVAL.

Thanks, but what about the subsequent close()? Will it fail with EINVAL? 
EBADF? or will is succeed (like on Linux)?

I will send an updated patch with all fixes, as soon as I know what to do 
about close().


...Johan

-- 
Johan Herland, [off-list ref]
www.herland.net