Re: [PATCH v3] quickfetch(): Prevent overflow of the rev-list command line

On Thu, Jul 09, 2009 at 04:21:09PM +0200, Johannes Sixt wrote:

Johan Herland schrieb:

quoted

On Thursday 09 July 2009, Johannes Sixt wrote:

quoted

Shouldn't you reset signal(SIGPIPE) to its previous value?

Done (provided that the sigchain_push/pop infrastructure works the way
I expect).

I'm not sure, either. Peff?

I don't think I ever tried explicitly pushing SIG_IGN, but the
infrastructure was designed so that it would Just Work. So yes, I think
it's right, but you may want to test it. :)

That being said, in the patch in question there is an early return after
the push that misses the corresponding pop. That should be fixed.

-Peff