Thread (18 messages) flat view 18 messages, 4 authors, 2016-06-15

Re: [PATCH] parse-opt: migrate builtin-ls-files.

From: Miklos Vajna <hidden>
Date: 2016-06-15 22:46:12

On Sun, Feb 15, 2009 at 09:13:42PM +0100, Johannes Schindelin [off-list ref] wrote:
quoted
quoted
quoted
+   dir->show_ignored = !unset;
+
+   return 0;
+}
Maybe this wants to be converted into an OPTION_BIT compatible data 
type?
I think that's not possible, as show_ignored is a bitfield.
Well, in my juvenile folly I dreamt of turning this into a proper 
bitfield...
Uhm, I think I haven't got what you mean. ;-)

Personally I would just remove all problematic bitfields in struct
dir_struct as I think it does not worth using them, but getting rid of
them just because of parseopt sounds insane as well - so I sended up
writing callback functions, as you saw in the patch.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help