Re: [PATCH 2/2] git wrapper: execute git-shell when argv[1] is '-c'

Hi,

On Tue, 26 Aug 2008, Tommi Virtanen wrote:

On Tue, Aug 26, 2008 at 12:05:21AM +0200, Johannes Schindelin wrote:

quoted

I do disagree with you that it is a kludge though.  I think it makes 
complete sense to add this to Documentation/git.txt in addition to 
other documentation that is lacking from my patch, though:

-- snip --
-c <command>::
	execute <command> in git-shell.
-- snap --

All I'm going to say is that that's not the way you build trustable 
software. You take a minimal interface and restrict untrusted users to 
that, you don't add a feature to the widest possible interface..

I do not get your point.

But then, I think I start not to care anymore, as I think your reasoning 
is bogus.  "widest possible interface", "trustable software", etc.  Sounds 
pretty buzzy-wordy to me.

Yeah, you would need to audit it.  Maybe you would even have to check for 
"*argv[0] == '-'" and set argv[0] to "git-shell" if so.  But buzz-wording 
just makes me go away and not listen anymore.

Whatever,
Dscho