Re: [EGIT PATCH] Comment private modifier to improve performace.

söndagen den 3 februari 2008 skrev Roger C. Soares:

With the else warnings patch I'm ok.

About the discouraged access, I read those warnings as: we are using 
methods that are not part of the eclipse public API and they can change 
in the future. Not depending on internal eclipse API will make egit less 
likely to break with a future eclipse version, which sounds like a good 
thing to me. So, I would keep those.

The thing with that one is that by default the warning is on, so removing
the setting doesn't remvoe the warning unless one disables it at the workspace
level. I'll hold it back for the moment anyway and push the "else" and "synthetic"
patches. Thanks for your opinions on the subject matter.

-- robin