Re: [EGIT PATCH] Comment private modifier to improve performace.
From: Robin Rosenberg <hidden>
Date: 2016-06-15 22:44:09
Subsystem:
the rest · Maintainer:
Linus Torvalds
lördagen den 2 februari 2008 skrev Roger C. Soares:
Changed private modifiers to default to improve perfomance and remove warnings of the type: Write access to enclosing field GitHistoryPage.hintShowDiffNow is emulated by a synthetic accessor method. Increasing its visibility will improve your performance
I'm not fully convinced this is the right way after all. Good performance is obviously good, but so is good encapsulation. I've sometimes tried changing things like this even in pieces of code that I really thought it should matter, but not been able to measure any real improvemen even with performance measurment tools. Obviously seeing that warning is annoying so maybe we should just set it to ignore or exclude it from the project settings (if that is possible). The only project where I think it might make a difference is the jgit part because that is where we optimize and that is where I experimented with visibility changes. In the Eclipse part we need to encapsulate more, partly because Eclipse is less understood by the current authors than Java in general. Encapsulation means encapsulating bad coding and bad design that comes from lack of understanding of the framework we are working within. -- robin From f26deb2c14e1df7513b3954594ea09b7746fcb69 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg <redacted> Date: Sun, 3 Feb 2008 01:46:33 +0100 Subject: [PATCH] Ignore warning for "Access to enclosing method/field X emulated by a synthetic accessor method" There is no measurable performance degradation from this. Increasing visibility of methods and fields in order to get rid of this warning reduces encapsulation. Instead of choosing the Ignore setting we remove the setting from the project, which may be somwhat hackish but has the benefit that the setting can be changed in the workspace for those that wants to investigate the issue. Signed-off-by: Robin Rosenberg <redacted> --- .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - 5 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs
index deec031..7a0fbe4 100644
--- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs
+++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled -org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
diff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs
index fa7a0b7..bcde160 100644
--- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs
+++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled -org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
diff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs
index 0ef7591..0a89f52 100644
--- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs
+++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled -org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
diff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
index 65d5c31..c203c20 100644
--- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
+++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled -org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
diff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs
index 4c38185..b0c694c 100644
--- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs
+++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled -org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
--
1.5.4.rc4.25.g81cc