Re: [EGIT PATCH] Comment private modifier to improve performace.
From: Roger C. Soares <hidden>
Date: 2016-06-15 22:44:09
With the else warnings patch I'm ok. About the discouraged access, I read those warnings as: we are using methods that are not part of the eclipse public API and they can change in the future. Not depending on internal eclipse API will make egit less likely to break with a future eclipse version, which sounds like a good thing to me. So, I would keep those. []s, Roger. -- Robin Rosenberg escreveu:
quoted hunk ↗ jump to hunk
We could drop these settings from the projects too. -- robin ------------------------------------------------------------------------ From a1aed72a122a05d01ed57db5d51b45debeb247b7 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg <redacted> Date: Sun, 3 Feb 2008 03:13:44 +0100 Subject: [PATCH] Make it possible to ignore warnings about discouraged access By removing the setting from the project the workspace settings will be applied (default: Warning) Signed-off-by: Robin Rosenberg <redacted> --- .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - 5 files changed, 0 insertions(+), 5 deletions(-)diff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs index 7a0fbe4..1c978ca 100644 --- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning org.eclipse.jdt.core.compiler.problem.deprecation=warning org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning org.eclipse.jdt.core.compiler.problem.emptyStatement=warning org.eclipse.jdt.core.compiler.problem.enumIdentifier=error org.eclipse.jdt.core.compiler.problem.fallthroughCase=warningdiff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs index bcde160..2afc050 100644 --- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning org.eclipse.jdt.core.compiler.problem.deprecation=warning org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning org.eclipse.jdt.core.compiler.problem.emptyStatement=warning org.eclipse.jdt.core.compiler.problem.enumIdentifier=error org.eclipse.jdt.core.compiler.problem.fallthroughCase=warningdiff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs index 0a89f52..0da92c7 100644 --- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning org.eclipse.jdt.core.compiler.problem.deprecation=warning org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning org.eclipse.jdt.core.compiler.problem.emptyStatement=warning org.eclipse.jdt.core.compiler.problem.enumIdentifier=error org.eclipse.jdt.core.compiler.problem.fallthroughCase=warningdiff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs index c203c20..9adf651 100644 --- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning org.eclipse.jdt.core.compiler.problem.deprecation=warning org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning org.eclipse.jdt.core.compiler.problem.emptyStatement=warning org.eclipse.jdt.core.compiler.problem.enumIdentifier=error org.eclipse.jdt.core.compiler.problem.fallthroughCase=warningdiff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs index b0c694c..faecf76 100644 --- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning org.eclipse.jdt.core.compiler.problem.deprecation=warning org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning org.eclipse.jdt.core.compiler.problem.emptyStatement=warning org.eclipse.jdt.core.compiler.problem.enumIdentifier=error org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning ------------------------------------------------------------------------From e9f312599eb5941a7bf1acd70c6f0ac9fb1ea889 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg <redacted> Date: Sun, 3 Feb 2008 03:19:09 +0100 Subject: [PATCH] Drop warnings about unnecessary else Use workspace setting, default ignore. Signed-off-by: Robin Rosenberg <redacted> --- .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 1 - .../.settings/org.eclipse.jdt.core.prefs | 3 +-- 5 files changed, 1 insertions(+), 6 deletions(-)diff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs index 1c978ca..7279d81 100644 --- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=errordiff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs index 2afc050..2d94530 100644 --- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=errordiff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs index 0da92c7..ff09222 100644 --- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=errordiff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs index 9adf651..b93093f 100644 --- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=errordiff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs index faecf76..4a5d15f 100644 --- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs +++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs@@ -1,4 +1,4 @@ -#Tue Dec 18 01:35:52 CET 2007 +#Sun Feb 03 03:16:45 CET 2008 eclipse.preferences.version=1 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error