Re: [PATCH] Add color to git-add--interactive diffs (Total different idea to solve the problem)

Hi,

On Tue, 23 Oct 2007, Peter Baumann wrote:

On Tue, Oct 23, 2007 at 12:55:44AM +0100, Johannes Schindelin wrote:

quoted

On Mon, 22 Oct 2007, Peter Baumann wrote:

quoted

Wouldn't it make more sense to implement the diff coloring inside 
git apply so that you could use something like

        diff file1 file2|git apply --color

to make the generated diff with colors [1]? It already implements 
the same semantic for generating a diffstat, using

        diff file1 file2|git apply --stat

No.  In both cases, "git diff" realises that the output is no terminal, 
and switches off color generation.  (Just try with diff.color=true instead 
of =auto.)

I didn't mean git-diff here, instead I meant diff, so no coloring involved
on the diff side. The git-apply would be enhanced to do the coloring on
every diff it gets on its STDIN.

Ah!  I completely misunderstood indeed.  Clever...

Ciao,
Dscho