Re: [PATCH] Add color to git-add--interactive diffs (Take 2: now without spurious line break!)

Hi,

On Sun, 14 Oct 2007, Wincent Colaiuta wrote:

quoted

+sub parse_color {

You could simplify the manual escape sequence construction that you're 
doing here by using Term::ANSIColor like the other patches did. I see 
that git-send-email.perl uses that module too, so I guess depending on 
that module is ok.

Wrong.  Depending on that module is not correct, you always have to wrap 
it into an "if (<is_color>) {...}".

I use git add -i quite often, and I _never_ use git send-email.  My guess 
is that I am not alone with that.

Ciao,
Dscho