Re: [PATCH] Add color to git-add--interactive diffs (Take 2: now without spurious line break!)

El 14/10/2007, a las 19:15, Johannes Schindelin escribió:

On Sun, 14 Oct 2007, Wincent Colaiuta wrote:

quoted

quoted

+sub parse_color {

You could simplify the manual escape sequence construction that  
you're
doing here by using Term::ANSIColor like the other patches did. I see
that git-send-email.perl uses that module too, so I guess  
depending on
that module is ok.

Wrong.  Depending on that module is not correct, you always have to  
wrap
it into an "if (<is_color>) {...}".

I use git add -i quite often, and I _never_ use git send-email.  My  
guess
is that I am not alone with that.

In that case I propose factoring out the escape sequence generation  
into git.pm, where it can be used by git-send-email, git-add-- 
interactive, or any other Perl script in Git. Do you think that's a  
good idea? If so I'll try whipping up a patch along those lines.

Wincent