Re: [PATCH] Change 'Deltifying objects' to 'Delta compressing objects'

On Thu, 18 Oct 2007, Jeff King wrote:

On Thu, Oct 18, 2007 at 10:45:31PM -0400, Nicolas Pitre wrote:

quoted

Yet that progress display isn't solely about "delta compressing".  It 
also includes the search for best object match in order to keep the 
smallest delta possible.

In fact, isn't that progress meter _solely_ about finding the best
matches? The actual deltification (that is, the creation of the deltas
and writing of them to the packfile happens during the writing phase --
unless, of course, we've cached the deltas during the search phase).

Well, to find which combination is the smallest you actually have to 
create deltas.

Perhaps one of:

  Finding deltas
  Finding delta candidates
  Matching objects

or something similar (though I don't especially like any of them, I
think you get the idea).

I think we might sidestep the issue entirely by remaining somewhat vague 
and simply saying "compressing objects" for that phase.  This is the 
part responsible for the reduction of a Git repository from 3GB down to 
200MB anyway.


Nicolas