Re: [dpdk-dev] [PATCH v16 8/9] eal: implement functions for thread barrier management
From: Narcisa Ana Maria Vasile <hidden>
Date: 2021-11-10 03:13:40
On Mon, Nov 08, 2021 at 06:07:34PM -0800, Narcisa Ana Maria Vasile wrote:
On Tue, Oct 12, 2021 at 06:32:09PM +0200, Thomas Monjalon wrote:quoted
09/10/2021 09:41, Narcisa Ana Maria Vasile:quoted
From: Narcisa Vasile <redacted> Add functions for barrier init, destroy, wait. A portable type is used to represent a barrier identifier. The rte_thread_barrier_wait() function returns the same value on all platforms. Signed-off-by: Narcisa Vasile <redacted> --- lib/eal/common/rte_thread.c | 61 ++++++++++++++++++++++++++++++++++++ lib/eal/include/rte_thread.h | 58 ++++++++++++++++++++++++++++++++++ lib/eal/version.map | 3 ++ lib/eal/windows/rte_thread.c | 56 +++++++++++++++++++++++++++++++++ 4 files changed, 178 insertions(+)It doesn't need to be part of the API. The pthread barrier is used only as part of the control thread implementation. The need disappear if you implement control thread on Windows.Actually I think I have the implementation already. I've worked at this some time ago, I have this patch: [v4,2/6] eal: add function for control thread creation The issue is I will break ABI so I cannot merge it as part of this patchset. I'll see if I can remove this barrier patch though.
I couldn't find a good way to test mutexes without barriers, so I kept this for now.