Re: [dpdk-dev] [PATCH v5 09/10] eal: add EAL argument for setting thread priority
From: Tal Shnaiderman <hidden>
Date: 2021-03-31 08:21:19
Subject: Re: [dpdk-dev] [PATCH v5 09/10] eal: add EAL argument for setting thread priority External email: Use caution opening links or attachments On Mon, 29 Mar 2021 15:40:39 -0700 Narcisa Ana Maria Vasile [off-list ref] wrote:quoted
From: Narcisa Vasile <redacted> Allow the user to choose the thread priority through an EAL command line argument. The user can select the thread priority to be either 'normal' or 'critical': --thread-prio normal --thread-prio realtime Signed-off-by: Narcisa Vasile <redacted>The discussion internally was that this was intended to resolve issues on Windows. So it makes sense for Windows, but it is not something that we want to have on Linux. Could you make this Windows only, and add update the documentation please. I just don't want Linux users discovering it, trying it, then reporting more bugs.
Windows needs it from performance aspects. However if we're keeping this option for Windows a warning like the one below from MSDN [1] should be added to docu: " A thread with a base priority level above 11 interferes with the normal operation of the operating system. Using REALTIME_PRIORITY_CLASS may cause disk caches to not flush, cause the mouse to stop responding, and so on. " [1] - https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-setthreadpriority