Re: [dpdk-dev] [PATCH v9 10/10] Enable the new EAL thread API
From: Narcisa Ana Maria Vasile <hidden>
Date: 2021-06-08 05:50:37
On Fri, Jun 04, 2021 at 04:44:34PM -0700, Narcisa Ana Maria Vasile wrote:
From: Narcisa Vasile <redacted> Rename pthread_* occurrences with the new rte_thread_* API. Enable the new API in the build system. Signed-off-by: Narcisa Vasile <redacted> ---
I'll send v10. Can someone please help with an example on how to check for ABI breaks? Thank you! I've run: DPDK_ABI_REF_VERSION=v21.05 DPDK_ABI_REF_DIR=~/ref ./devtools/test-meson-builds.sh which doesn't give any warnings about the ABI break. I've cloned the dpdk repo in "~/ref" and checkout v21.05 tag. "~/dpdk" is on a local branch that contains my changes: "./devtools/check-abi.sh ~/ref ~/dpdk" - didn't work. I've then used gen-abi.sh (with a small change to skip the *.symbols, since abidw can't handle them) to generate the *.dump files. Reruning check-abi.sh worked this time, but didn't show the ABI break. This is the entire output: ------ WARNING: could not identify an include directory for /home/administrator/ref, expect false positives... WARNING: could not identify an include directory for /home/administrator/dpdk, expect false positives... Functions changes summary: 0 Removed, 0 Changed, 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable Variable symbols changes summary: 0 Removed, 0 Added variable symbol not referenced by debug info ------ I've also tried to compare each file: abidiff --suppr ./devtools/libabigail.abignore --no-added-syms ~/ref/dump/librte_eal.dump ~/dpdk/dump/librte_eal.dump