On 11/5/2021 9:28 AM, Andrew Rybchenko wrote:

quoted

On 11/5/21 12:13 PM, Ferruh Yigit wrote:

quoted

On 11/3/2021 1:57 PM, Vijay Srivastava wrote:

quoted

diff --git a/drivers/vdpa/sfc/sfc_vdpa.c

b/drivers/vdpa/sfc/sfc_vdpa.c new file mode 100644 index
0000000..f087944

--- /dev/null
+++ b/drivers/vdpa/sfc/sfc_vdpa.c

@@ -0,0 +1,282 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ *
+ * Copyright(c) 2020-2021 Xilinx, Inc.
+ */
+

Only sfc has that blank line between SPDX tag and Copyright, is it
intentional?

As far as I remember it is not intentional. Just coincident and may be
definitely fixed in vdpa/sfc.

quoted

+Hemant, not sure if we enforce any specific syntax?


If there is no specific reason, I think better to have common syntax,
that helps to scripts etc..
It may be noise to update existing code, but we can fix it in new
code.

+1

If there is not objection, I will remove that empty lines in this set, while
merging next-net.

[Hemant] I saw it late.
 There is no restrictions to have blank lines between copyright and SPDX. But it looks clean without that.