Hi Maxime, 

-----Original Message-----
From: Maxime Coquelin <redacted>
Sent: Monday, August 30, 2021 7:18 PM
To: Vijay Kumar Srivastava <redacted>; dev@dpdk.org
Cc: chenbo.xia@intel.com; andrew.rybchenko@oktetlabs.ru; Vijay Kumar
Srivastava [off-list ref]
Subject: Re: [PATCH 08/10] vdpa/sfc: add support for MAC filter config



On 7/6/21 6:44 PM, Vijay Srivastava wrote:

quoted

From: Vijay Kumar Srivastava <redacted>

Add support for unicast and broadcast MAC filter configuration.

I wonder whether we should not add an API to the vDPA framework for this
MAC management, as this is something generic.

What do you think?

I think it's good idea to add an API for MAC configuration in vDPA framework. 

quoted

Signed-off-by: Vijay Kumar Srivastava <redacted>
---
 doc/guides/vdpadevs/sfc.rst        |   4 ++
 drivers/vdpa/sfc/meson.build       |   1 +
 drivers/vdpa/sfc/sfc_vdpa.c        |  32 +++++++++
 drivers/vdpa/sfc/sfc_vdpa.h        |  30 ++++++++
 drivers/vdpa/sfc/sfc_vdpa_filter.c | 144

+++++++++++++++++++++++++++++++++++++

quoted

 drivers/vdpa/sfc/sfc_vdpa_hw.c     |  10 +++
 drivers/vdpa/sfc/sfc_vdpa_ops.c    |  17 +++++
 7 files changed, 238 insertions(+)
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c