-----Original Message-----
From: Andrew Rybchenko <redacted>
Sent: Monday, November 1, 2021 5:00 PM
To: Xia, Chenbo <redacted>; Vijay Srivastava
[off-list ref]; dev@dpdk.org
Cc: maxime.coquelin@redhat.com; Vijay Kumar Srivastava <redacted>
Subject: Re: [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver

Hi Chenbo,

Thanks for review.
Few questions from me below on your review notes.

Andrew.

On 11/1/21 11:30 AM, Xia, Chenbo wrote:

quoted

Hi Vijay,

quoted

-----Original Message-----
From: Vijay Srivastava <redacted>
Sent: Friday, October 29, 2021 10:47 PM
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com; Xia, Chenbo <redacted>;
andrew.rybchenko@oktetlabs.ru; Vijay Kumar Srivastava [off-list ref]
Subject: [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver

From: Vijay Kumar Srivastava <redacted>

Add new vDPA PMD to support vDPA operations of Xilinx devices.
This patch implements probe and remove functions.

Signed-off-by: Vijay Kumar Srivastava <redacted>
Acked-by: Andrew Rybchenko <redacted>

Note that your patch is not rebased on the latest commit. Reviewers
may have trouble to review your patch.

[snip]

quoted

quoted

+	sva->vfio_group_fd =
+		rte_vfio_container_group_bind(sva->vfio_container_fd,

DPDK allows up to 100 chars per line. Please check all code that do not
need new lines. It will make the code look better.

I'm sorry, but as far as I know permissive to have up to 100 chars
does not enforce to stretch all lines. Or am I missing something in
coding style? IMHO, it is still *allowed* to avoid lines longer than
80 chars.

You are correct. 80 chars is still allowed. You can keep it if it's your
preference. I just thought most people would choose 100 chars for a case
above. But you can choose on your own :)

/Chenbo

[snip]