Re: [dpdk-dev] [EXT] Re: [PATCH v4 14/14] eventdev: mark trace variables as internal
From: Pavan Nikhilesh Bhagavatula <hidden>
Date: 2021-10-18 15:07:25
On Sat, Oct 16, 2021 at 12:34 AM [off-list ref] wrote:quoted
From: Pavan Nikhilesh <redacted> Mark rte_trace global variables as internal i.e. remove them from experimental section of version map. Some of them are used in inline APIs, mark those as global. Signed-off-by: Pavan Nikhilesh <redacted> Acked-by: Ray Kinsella <redacted> --- doc/guides/rel_notes/release_21_11.rst | 12 +++++ lib/eventdev/version.map | 71 ++++++++++++-------------- 2 files changed, 44 insertions(+), 39 deletions(-)diff --git a/doc/guides/rel_notes/release_21_11.rstb/doc/guides/rel_notes/release_21_11.rstquoted
index 38e601c236..5b4a05c3ae 100644--- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst@@ -226,6 +226,9 @@ API Changes the crypto/security operation. This field will be used to communicate events such as soft expiry with IPsec in lookaside mode. +* eventdev: Event vector configuration APIs have been made stable. + Move memory used by timer adapters to hugepage. This willprevent TLB missesquoted
+ if any and aligns to memory structure of other subsystems. ABI Changes -----------@@ -277,6 +280,15 @@ ABI Changes were added in structure ``rte_event_eth_rx_adapter_stats`` to getadditionalquoted
status. +* eventdev: A new structure ``rte_event_fp_ops`` has been addedwhich is now usedquoted
+ by the fastpath inline functions. The structures ``rte_eventdev``, + ``rte_eventdev_data`` have been made internal.``rte_eventdevs[]`` can't bequoted
+ accessed directly by user any more. This change is transparent tobothquoted
+ applications and PMDs. + +* eventdev: Re-arrange fields in ``rte_event_timer`` to removeholes.quoted
+ ``rte_event_timer_adapter_pmd.h`` has been made internal.Looks good. Please fix the following, If there are no objections, I will merge the next version. 1) Please move the doc update to respective patches
Ack, will move in next version.
2) Following checkpath issue [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 14 ### eventdev: move inline APIs into separate structure INFO: symbol event_dev_fp_ops_reset has been added to the INTERNAL section of the version map INFO: symbol event_dev_fp_ops_set has been added to the INTERNAL section of the version map INFO: symbol event_dev_probing_finish has been added to the INTERNAL section of the version map
These can be ignored as they are internal
ERROR: symbol rte_event_fp_ops is added in the DPDK_22 section, but is expected to be added in the EXPERIMENTAL section of the version map
This is a replacement for rte_eventdevs, ethdev rework also doesn’t mark it as experimental. @David Marchand @Ray Kinsella any opinions?