Hi Erik,

Hi Pavan,

One comment in-line:

quoted

-----Original Message-----
From: pbhagavatula@marvell.com <redacted>
Sent: Monday, August 23, 2021 2:40 PM
To: jerinj@marvell.com; Carrillo, Erik G <redacted>
Cc: Ananyev, Konstantin <redacted>;

dev@dpdk.org;

quoted

Pavan Nikhilesh [off-list ref]
Subject: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer

object

quoted

From: Pavan Nikhilesh <redacted>

Reserve fields in rte_event_timer data structure to address future

use cases.

quoted

Also, remove volatile from rte_event_timer.

Signed-off-by: Pavan Nikhilesh <redacted>
---
 lib/eventdev/rte_event_timer_adapter.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/eventdev/rte_event_timer_adapter.h

b/lib/eventdev/rte_event_timer_adapter.h
index cad6d3b4c5..9499460a61 100644

--- a/lib/eventdev/rte_event_timer_adapter.h
+++ b/lib/eventdev/rte_event_timer_adapter.h

@@ -475,7 +475,7 @@ struct rte_event_timer {
 	 *  - op: RTE_EVENT_OP_NEW
 	 *  - event_type: RTE_EVENT_TYPE_TIMER
 	 */
-	volatile enum rte_event_timer_state state;
+	enum rte_event_timer_state state;
 	/**< State of the event timer. */
 	uint64_t timeout_ticks;
 	/**< Expiry timer ticks expressed in number of

*timer_ticks_ns*

quoted

from @@ -492,6 +492,8 @@ struct rte_event_timer {
 	/**< Memory to store user specific metadata.
 	 * The event timer adapter implementation should not modify

this

quoted

area.
 	 */
+	uint64_t rsvd[2];
+	/**< Reserved fields for future use. */

This placement puts rsvd after the user_meta field, which should be last
since it is a zero-length array.  Am I missing something?

My bad, I will fix it in next version.

Thanks,
Erik

Thanks,
Pavan.

quoted

 } __rte_cache_aligned;

 typedef uint16_t (*rte_event_timer_arm_burst_t)(
--
2.17.1