Thread (119 messages) 119 messages, 12 authors, 2021-10-20

Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2021-08-24 15:10:58

On Tue, 24 Aug 2021 01:10:15 +0530
[off-list ref] wrote:
From: Pavan Nikhilesh <redacted>

Reserve fields in rte_event_timer data structure to address future
use cases.
Also, remove volatile from rte_event_timer.

Signed-off-by: Pavan Nikhilesh <redacted>
Reserve fields are not a good idea. They don't solve future API/ABI problems.

The issue is that you need to zero them and check they are zero otherwise
they can't safely be used later.  This happened with the Linux kernel
system calls where in several cases a flag field was added for future.
The problem is that old programs would work with any garbage in the flag
field, and therefore the flag could not be extended.

A better way to make structures internal opaque objects that
can be resized.  Why is rte_event_timer_adapter exposed in API?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help