On 10/13/2021 3:42 AM, Wang, Jie1X wrote:

quoted

-----Original Message-----
From: Yigit, Ferruh <redacted>
Sent: Tuesday, October 12, 2021 10:38 PM
To: Wang, Jie1X <redacted>; dev@dpdk.org
Cc: thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; Li, Xiaoyun
[off-list ref]; Yang, SteveX [off-list ref]
Subject: Re: [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash
offload

On 10/12/2021 3:54 AM, Jie Wang wrote:

quoted

The driver may change offloads info into dev->data->dev_conf in
dev_configure which may cause port->dev_conf and port->rx_conf contain
outdated values.

This patch updates the offloads info if it changes to fix this issue.

Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")

Signed-off-by: Jie Wang <redacted>

Hi Jie,

ci/intel-Testing is still reporting some errors [1] with this patch, did you able to
investigate the reason of it?

This error seems not seen in other patches, so that shouldn't be an infrastructure
problem.


[1]
http://mails.dpdk.org/archives/test-report/2021-October/226766.html

Hi Ferruh,

When the dpdk runs the test_pf_tx_rx_queue test case, the port will be configured with rxq/txq to 1. This will cause the test to fail.

In rte_eth_dev_configure, if rxq/txq is 1, dev_conf->rxmode.mq_mode is ETH_MQ_RX_NONE, and  dev_conf->rxmode.offloads contains the DEV_RX_OFFLOAD_RSS_HASH value by default, which causes the program to report an error " Ethdev port_id=0 config invalid Rx mq_mode without RSS but RSS_HASH offload is requested".

When the port needs to configure txq/txq to 1, first clear the RSS_HASH configuration of dev_conf->rxmode.offloads.

And I have talked about this error with the tester a few days ago, and they will modify the test case. They will add a command (port config port_id rx_offload rss_hash off) before configuring txq/rxq to 1.

I see, but shouldn't this fail for all patches, why it is only failing
for this set?