Re: [dpdk-dev] [PATCH v12 1/2] ethdev: add an API to get device configuration
From: Andrew Rybchenko <hidden>
Date: 2021-10-12 05:50:59
On 10/12/21 5:54 AM, Jie Wang wrote:
The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause apps use outdated values. Add a new API to get actual device configuration. Signed-off-by: Jie Wang <redacted>
Acked-by: Andrew Rybchenko <redacted> [snip]
quoted hunk ↗ jump to hunk
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 6d80514ba7..7b5d5fb379 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h@@ -3052,6 +3052,26 @@ int rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr); */ int rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info); +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Retrieve the configuration of an Ethernet device. + * + * @param port_id + * The port identifier of the Ethernet device. + * @param dev_conf + * A pointer to a structure to be filled with the configuration of + * the Ethernet device. + * Location for Ethernet device configuration to be filled in.
IMHO just the second sentence is sufficient.
+ * @return + * - (0) if successful. + * - (-ENODEV) if *port_id* invalid. + * - (-EINVAL) if bad parameter. + */ +__rte_experimental +int rte_eth_dev_conf_get(uint16_t port_id, struct rte_eth_conf *dev_conf); + /** * Retrieve the firmware version of a device. *
[snip]