-----Original Message-----
From: stable <redacted> On Behalf Of Li, Xiaoyun
Sent: Thursday, July 15, 2021 12:54
To: Wang, Jie1X <redacted>; dev@dpdk.org
Cc: andrew.rybchenko@oktetlabs.ru; stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v4] app/testpmd: fix testpmd doesn't show
RSS hash offload

quoted

-----Original Message-----
From: Wang, Jie1X <redacted>
Sent: Thursday, July 15, 2021 19:57
To: dev@dpdk.org
Cc: Li, Xiaoyun <redacted>; andrew.rybchenko@oktetlabs.ru;
Wang, Jie1X [off-list ref]; stable@dpdk.org
Subject: [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash
offload

The driver may change offloads info into dev->data->dev_conf in
dev_configure which may cause port->dev_conf and port->rx_conf contain

outdated values.

quoted

This patch updates the offloads info if it changes to fix this issue.

Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Cc: stable@dpdk.org

Signed-off-by: Jie Wang <redacted>
---
v4: delete the whitespace at the end of the line.
v3:
 - check and update the "offloads" of "port->dev_conf.rx/txmode".
 - update the commit log.
v2: copy "rx/txmode.offloads", instead of copying the entire struct
"dev->data-

quoted

dev_conf.rx/txmode".

---
 app/test-pmd/testpmd.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Acked-by: Xiaoyun Li <redacted>

Although I gave my ack, app shouldn't touch rte_eth_devices which this patch does. Usually, testpmd should only call function like eth_dev_info_get_print_err().
But dev_info doesn't contain the info dev->data->dev_conf which the driver modifies.

Probably we need a better fix.