Re: [dpdk-dev] [PATCH v2 3/5] app/testpmd: fix RSS type display
From: Xia, Chenbo <hidden>
Date: 2021-09-23 07:59:35
quoted hunk ↗ jump to hunk
-----Original Message----- From: Maxime Coquelin <redacted> Sent: Wednesday, September 22, 2021 5:58 PM To: dev@dpdk.org; Xia, Chenbo <redacted>; amorenoz@redhat.com; david.marchand@redhat.com; andrew.rybchenko@oktetlabs.ru; Yigit, Ferruh [off-list ref]; michaelba@nvidia.com; viacheslavo@nvidia.com; Li, Xiaoyun [off-list ref] Cc: stable@dpdk.org; nelio.laranjeiro@6wind.com; yvugenfi@redhat.com; ybendito@redhat.com; Maxime Coquelin [off-list ref] Subject: [PATCH v2 3/5] app/testpmd: fix RSS type display This patch fixes the display of the RSS hash types configured in the port, which displayed "all" even if only a single type was configured Fixes: 3c90743dd3b9 ("app/testpmd: support more types for flow RSS") Cc: stable@dpdk.org Signed-off-by: Maxime Coquelin <redacted> --- app/test-pmd/config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 611965769c..9a4a0c232b 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c@@ -2833,7 +2833,9 @@ port_rss_hash_conf_show(portid_t port_id, intshow_rss_key) } printf("RSS functions:\n "); for (i = 0; rss_type_table[i].str; i++) { - if (rss_hf & rss_type_table[i].rss_type) + if (rss_type_table[i].rss_type == 0) + continue; + if ((rss_hf & rss_type_table[i].rss_type) == rss_type_table[i].rss_type) printf("%s ", rss_type_table[i].str); } printf("\n"); -- 2.31.1
Reviewed-by: Chenbo Xia <redacted>