Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support
From: Maxime Coquelin <hidden>
Date: 2021-09-22 12:28:44
On 9/22/21 13:20, Andrew Rybchenko wrote:
On 9/22/21 12:57 PM, Maxime Coquelin wrote:quoted
Provide the capability to update the hash key, hash types and RETA table on the fly (without needing to stop/start the device). However, the key length and the number of RETA entries are fixed to 40B and 128 entries respectively. This is done in order to simplify the design, but may be revisited later as the Virtio spec provides this flexibility. Note that only VIRTIO_NET_F_RSS support is implemented, VIRTIO_NET_F_HASH_REPORT, which would enable reporting the packet RSS hash calculated by the device into mbuf.rss, is not yet supported. Regarding the default RSS configuration, it has been chosen to use the default Intel ixgbe key as default key, and default RETA is a simple modulo between the hash and the number of Rx queues. Signed-off-by: Maxime Coquelin <redacted>RSS may be configured on rte_eth_dev_configure() stage using eth_conf->rx_adv_conf.rss_conf. It looks like the patch does not handle it.
Good catch, I indeed missed that part. I'll post a v3 including its support. Thanks, Maxime