Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: add missing flow types in port info
From: Li, Xiaoyun <hidden>
Date: 2021-09-22 11:31:10
Hi
quoted hunk ↗ jump to hunk
-----Original Message----- From: Maxime Coquelin <redacted> Sent: Wednesday, September 22, 2021 17:58 To: dev@dpdk.org; Xia, Chenbo <redacted>; amorenoz@redhat.com; david.marchand@redhat.com; andrew.rybchenko@oktetlabs.ru; Yigit, Ferruh [off-list ref]; michaelba@nvidia.com; viacheslavo@nvidia.com; Li, Xiaoyun [off-list ref] Cc: stable@dpdk.org; nelio.laranjeiro@6wind.com; yvugenfi@redhat.com; ybendito@redhat.com; Maxime Coquelin [off-list ref] Subject: [PATCH v2 5/5] app/testpmd: add missing flow types in port info This patch adds missing IPv6-Ex flow types to port info command. Signed-off-by: Maxime Coquelin <redacted> --- app/test-pmd/config.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index9a4a0c232b..3550e0a18f 100644--- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c@@ -4528,6 +4528,9 @@ flowtype_to_str(uint16_t flow_type) {"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP}, {"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER}, {"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD}, + {"ipv6-ex", RTE_ETH_FLOW_IPV6_EX}, + {"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX}, + {"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX}, {"port", RTE_ETH_FLOW_PORT}, {"vxlan", RTE_ETH_FLOW_VXLAN}, {"geneve", RTE_ETH_FLOW_GENEVE},
You add missing ipv6 ex why not adding RTE_ETH_FLOW_GTPU too. It's also missing. Also, flowtype_to_str is added but what about str2flowtype() in cmdline.c?
-- 2.31.1