20/07/2021 14:14, David Marchand:

quoted

On Tue, Jul 20, 2021 at 1:59 PM Akhil Goyal [off-list ref] wrote:

quoted

 Hi David,

quoted

quoted

quoted

 deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev',

'net_octeontx']

quoted

+deps += ['crypto_octeontx']

This extra dependency resulted in disabling the event/octeontx driver
in FreeBSD, since crypto/octeontx only builds on Linux.
Removing hw support triggers a ABI failure for FreeBSD.


- This had been reported by UNH CI:
https://urldefense.proofpoint.com/v2/url?u=http-

3A__mails.dpdk.org_archives_test-2Dreport_2021-
2DJune_200637.html&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2
wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=zikYn88P-
Q3H517Go0NWLsokSeUCheJhQyY-Rh-
DAWQ&s=v6vmJJNBDxjoA81J4rpuxvgPhR8DCT6qizgAkXauZIY&e=

quoted

quoted

quoted

quoted

It seems the result has been ignored but it should have at least
raised some discussion.

This was highlighted to CI ML
https://urldefense.proofpoint.com/v2/url?u=http-

3A__patches.dpdk.org_project_dpdk_patch_0686a7c3fb3a22e37378a8545b
&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu6
8gBzn7DkPwuqhd6WNyo&m=zikYn88P-Q3H517Go0NWLsokSeUCheJhQyY-
Rh-DAWQ&s=68Xkwo5J0d3BngYD0gxM0JKIgDzd58pypXyJrprGIgA&e=

quoted

quoted

quoted

c37bce04f4c391.1624481225.git.sthotton@marvell.com/

but I think I missed to take the follow up with Brandon and applied the

patch

quoted

quoted

quoted

as it did not look an issue to me as octeon drivers are not currently built

on

quoted

quoted

quoted

FreeBSD.
Not sure why event driver is getting built there.

quoted

- I asked UNH to stop testing FreeBSD abi for now, waiting to get the
main branch fixed.

I don't have the time to look at this, please can you work on it?

Several options:
* crypto/octeontx is made so that it compiles on FreeBSD,
* the abi check is extended to have exceptions per OS,
* the FreeBSD abi reference is regenerated at UNH not to have those
drivers in it (not sure it is doable),

Thanks for the suggestions, we are working on it to resolve this as soon

as

quoted

quoted

quoted

possible.
We may need to add exception in ABI checking so that it does not shout

if a

quoted

quoted

quoted

PMD
is not compiled.

Can we have below change? Will it work to disable compilation of
event/octeontx2 for FreeBSD? I believe this was done by mistake earlier
as all other octeontx2 drivers are compiled off on platforms other than

Linux.

quoted

quoted

diff --git a/drivers/event/octeontx2/meson.build

b/drivers/event/octeontx2/meson.build

quoted

quoted

index 96ebb1f2e7..1ebc51f73f 100644

--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build

@@ -2,7 +2,7 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #

-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
     reason = 'only supported on 64-bit'
     subdir_done()

I did not suggest this possibility.
That's the same as for other octeon drivers, such change has been
deferred to 21.11.
https://urldefense.proofpoint.com/v2/url?u=https-

3A__patches.dpdk.org_project_dpdk_list_-3Fseries-
3D15885&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9T
Wey3eu68gBzn7DkPwuqhd6WNyo&m=zikYn88P-
Q3H517Go0NWLsokSeUCheJhQyY-Rh-
DAWQ&s=A5fHouoeBcH2sL_xt5dtzRwfA8Fq__eBUYc-J9ANBIg&e=

quoted

quoted

Or of this does not work, then we would need to add exception in ABI

checking.

quoted

quoted

Any suggestions how to do this?

Sorry, no good idea from me.

We would need to revert the change breaking the ABI test.
But I don't understand why it seems passing in recent CI runs?

It is passing because FreeBSD is currently skipped. Right David?
BTW, no need to revert, we would be sending a patch to enable compilation
of crypto/octeontx