Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework
From: David Marchand <hidden>
Date: 2021-07-20 12:14:37
On Tue, Jul 20, 2021 at 1:59 PM Akhil Goyal [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Hi David,quoted
quoted
quoted
deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev','net_octeontx']quoted
+deps += ['crypto_octeontx']This extra dependency resulted in disabling the event/octeontx driver in FreeBSD, since crypto/octeontx only builds on Linux. Removing hw support triggers a ABI failure for FreeBSD. - This had been reported by UNH CI: http://mails.dpdk.org/archives/test-report/2021-June/200637.html It seems the result has been ignored but it should have at least raised some discussion.This was highlighted to CI ML http://patches.dpdk.org/project/dpdk/patch/0686a7c3fb3a22e37378a8545b c37bce04f4c391.1624481225.git.sthotton@marvell.com/ but I think I missed to take the follow up with Brandon and applied the patch as it did not look an issue to me as octeon drivers are not currently built on FreeBSD. Not sure why event driver is getting built there.quoted
- I asked UNH to stop testing FreeBSD abi for now, waiting to get the main branch fixed. I don't have the time to look at this, please can you work on it? Several options: * crypto/octeontx is made so that it compiles on FreeBSD, * the abi check is extended to have exceptions per OS, * the FreeBSD abi reference is regenerated at UNH not to have those drivers in it (not sure it is doable),Thanks for the suggestions, we are working on it to resolve this as soon as possible. We may need to add exception in ABI checking so that it does not shout if a PMD is not compiled.Can we have below change? Will it work to disable compilation of event/octeontx2 for FreeBSD? I believe this was done by mistake earlier as all other octeontx2 drivers are compiled off on platforms other than Linux.diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build index 96ebb1f2e7..1ebc51f73f 100644 --- a/drivers/event/octeontx2/meson.build +++ b/drivers/event/octeontx2/meson.build@@ -2,7 +2,7 @@ # Copyright(C) 2019 Marvell International Ltd. # -if not dpdk_conf.get('RTE_ARCH_64') +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') build = false reason = 'only supported on 64-bit' subdir_done()
I did not suggest this possibility. That's the same as for other octeon drivers, such change has been deferred to 21.11. https://patches.dpdk.org/project/dpdk/list/?series=15885
Or of this does not work, then we would need to add exception in ABI checking. Any suggestions how to do this?
Sorry, no good idea from me. -- David Marchand