Re: [dpdk-dev] [PATCH v2 1/2] drivers: add octeontx crypto adapter framework
From: David Marchand <hidden>
Date: 2021-07-15 14:22:17
Hello, On Wed, Jun 23, 2021 at 10:54 PM Shijith Thotton [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build index 3cb140b4de..0d9eec3f2e 100644 --- a/drivers/event/octeontx/meson.build +++ b/drivers/event/octeontx/meson.build@@ -12,3 +12,4 @@ sources = files( ) deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', 'net_octeontx'] +deps += ['crypto_octeontx']
This extra dependency resulted in disabling the event/octeontx driver in FreeBSD, since crypto/octeontx only builds on Linux. Removing hw support triggers a ABI failure for FreeBSD. - This had been reported by UNH CI: http://mails.dpdk.org/archives/test-report/2021-June/200637.html It seems the result has been ignored but it should have at least raised some discussion. - I asked UNH to stop testing FreeBSD abi for now, waiting to get the main branch fixed. I don't have the time to look at this, please can you work on it? Several options: * crypto/octeontx is made so that it compiles on FreeBSD, * the abi check is extended to have exceptions per OS, * the FreeBSD abi reference is regenerated at UNH not to have those drivers in it (not sure it is doable), Thanks. -- David Marchand