[dpdk-dev] [PATCH V3] table: fix bucket empty logic
From: Thierry Herbelot <hidden>
Date: 2021-07-07 11:19:26
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
From: Thierry Herbelot <hidden>
Date: 2021-07-07 11:19:26
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
Due to a typo, only 3 out of 4 keys in the bucket of the exact match
table were considered, which can result in valid keys being
incorrectly dropped from the table.
Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: stable@dpdk.org
Cc: Cristian Dumitrescu <redacted>
Signed-off-by: Thierry Herbelot <redacted>
--
V3: reword commit log
V2: reword patch title
---
lib/table/rte_swx_table_em.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
index 788e25f6b912..03b28c4c9da0 100644
--- a/lib/table/rte_swx_table_em.c
+++ b/lib/table/rte_swx_table_em.c@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id) static inline int bkt_is_empty(struct bucket_extension *bkt) { - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) ? + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) ? 1 : 0; }
--
2.29.2