Thread (18 messages) 18 messages, 3 authors, 2021-07-09

Re: [dpdk-dev] [PATCH v2] table: fix typo

From: Dumitrescu, Cristian <hidden>
Date: 2021-05-24 11:31:32

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Thierry Herbelot <redacted>
Sent: Monday, May 24, 2021 12:29 PM
To: dev@dpdk.org
Cc: Thierry Herbelot <redacted>; Thomas Monjalon
[off-list ref]; stable@dpdk.org; Dumitrescu, Cristian
[off-list ref]
Subject: [PATCH v2] table: fix typo

Check Bucket key for all possible indices.

Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: stable@dpdk.org
Cc: Cristian Dumitrescu <redacted>

Signed-off-by: Thierry Herbelot <redacted>
--
V2: reword patch title
---
 lib/table/rte_swx_table_em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
index 788e25f6b912..03b28c4c9da0 100644
--- a/lib/table/rte_swx_table_em.c
+++ b/lib/table/rte_swx_table_em.c
@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
 static inline int
 bkt_is_empty(struct bucket_extension *bkt)
 {
-	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
?
+	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
?
 		1 : 0;
 }

--
2.29.2
Acked-by: Cristian Dumitrescu <redacted>

Thierry, thanks again, you could have actually added my ack from V1 :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help