Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo
From: Thomas Monjalon <hidden>
Date: 2021-06-21 16:14:52
21/06/2021 17:54, Thierry Herbelot:
On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:quoted
From: Thierry Herbelot <redacted>quoted
On 6/17/21 9:01 AM, Thomas Monjalon wrote:quoted
quoted
quoted
Check Bucket key for all possible indices. Fixes: d0a00966618ba ("table: add exact match SWX table") Cc: stable@dpdk.org Cc: Cristian Dumitrescu <redacted> Signed-off-by: Thierry Herbelot <redacted>[...]quoted
quoted
- return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])Acked-by: Cristian Dumitrescu <redacted> Thierry, thanks again, you could have actually added my ack from V1 :)The root cause looks to be a typo indeed, but the impact or the scope of the issue should stated in few words in the title please. No need to send a v3, please suggest a title and I will apply.table: check a bucket is empty for all bucket keys ThierryHi Thierry, I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?
No need to send a v3.
Hello Cristian Sure ! What do you think of this title: "table: check a bucket is empty for all bucket keys"
This title suggests it was not the intent before. It should say that it fixes this check, or better, name the area of the API which is fixed.