Re: [dpdk-dev] [PATCH v6 5/5] net: replace Windows networking shim
From: Dmitry Kozlyuk <hidden>
Date: 2021-04-01 23:03:43
From: Dmitry Kozlyuk <hidden>
Date: 2021-04-01 23:03:43
2021-03-26 10:28 (UTC+0100), Thomas Monjalon:
20/03/2021 14:05, Dmitry Kozlyuk:
[...]
quoted
--- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c@@ -22,6 +22,7 @@ #include <rte_sctp.h> #include <rte_hash_crc.h> #include <rte_bitmap.h> +#include <rte_os_internal.h>Why is it needed?
I deliberately put all shim definitions, like missing IPPROTO_* constants that are used in this file, in <rte_os_internal.h> so that they are never exposed to DPDK users. Other inclusions of this file have the same reason.