Re: [dpdk-dev] [PATCH v6 2/5] eal/windows: hide asprintf() shim
From: Thomas Monjalon <hidden>
Date: 2021-03-26 09:04:31
From: Thomas Monjalon <hidden>
Date: 2021-03-26 09:04:31
20/03/2021 14:05, Dmitry Kozlyuk:
Make asprintf(3) implementation for Windows private to EAL, so that it's hidden from external consumers. It is not exposed to internal consumers either, because they don't need asprintf() and also because callers from other modules would have no reliable way to free allocated memory. Signed-off-by: Dmitry Kozlyuk <redacted> Acked-by: Khoa To <redacted> --- lib/librte_eal/common/eal_private.h | 11 +++++++++++ lib/librte_eal/windows/eal.c | 30 +++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+)
It would be logic to remove the asprintf implementation from rte_os.h in this patch.