Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions
From: Nick Connolly <hidden>
Date: 2021-03-02 11:27:53
From: Nick Connolly <hidden>
Date: 2021-03-02 11:27:53
quoted
DPDK supports a variety of platforms and toolsets and my experience with SPDK suggests that we'll end up with compiler specific ifdef's.I'd argue they are inevitable. Consider POSIX close(): if it's missing, what would be a correct fallback? It depends on the execution environment (OS). String function fallbacks, of course, are easily implemented from scratch.
Agreed.
quoted
Public functions without rte_ prefix shall not be introduced at all.
Agreed. Perhaps as a separate patch we should consider validation rules to enforce the requirements. Regards, Nick