Thread (130 messages) 130 messages, 16 authors, 2021-03-23

Re: [dpdk-dev] [PATCH v7 02/17] buildtools: fix build with busybox

From: Kinsella, Ray <hidden>
Date: 2021-03-22 09:01:25


On 22/03/2021 08:55, Thomas Monjalon wrote:
22/03/2021 09:52, Kinsella, Ray:
quoted
On 19/03/2021 14:57, Thomas Monjalon wrote:
quoted
--- a/buildtools/check-symbols.sh
+++ b/buildtools/check-symbols.sh
-DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump)
+DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXXXXX)
Does it make sense to change it to

DUMPFILE=$(mktemp -t dpdk.${0##*/}.objdump.XXXXXX)

So we can preserve what the file is in the filename?
Yes could be.
There is already the name of the script in the temp filename,
but I am OK to add more details.

If there is no other comment, I will change when applying.
Nothing from me ...
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help