Re: [dpdk-dev] [PATCH v7 15/17] event/dlb: fix header includes for musl
From: McDaniel, Timothy <hidden>
Date: 2021-03-19 15:47:39
quoted hunk ↗ jump to hunk
-----Original Message----- From: Thomas Monjalon <redacted> Sent: Friday, March 19, 2021 9:57 AM To: dev@dpdk.org Cc: ncopa@alpinelinux.org; stable@dpdk.org; Andrew Rybchenko [off-list ref]; David Marchand [off-list ref]; McDaniel, Timothy [off-list ref]; Gage Eads [off-list ref] Subject: [PATCH v7 15/17] event/dlb: fix header includes for musl The header file fcntl.h should not be included from sys/ directory as done in dlb drivers, it is an error with musl libc. Fixes: 19980083fd57 ("event/dlb: add eventdev probe") Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon <redacted> Acked-by: Andrew Rybchenko <redacted> Acked-by: David Marchand <redacted> --- drivers/event/dlb/dlb.c | 2 +- drivers/event/dlb/pf/dlb_pf.c | 3 ++- drivers/event/dlb2/dlb2.c | 2 +- drivers/event/dlb2/pf/dlb2_pf.c | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-)diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 1174ab3d2b..60084ced3b 100644 --- a/drivers/event/dlb/dlb.c +++ b/drivers/event/dlb/dlb.c@@ -10,7 +10,7 @@ #include <stdint.h> #include <stdio.h> #include <string.h> -#include <sys/fcntl.h> +#include <fcntl.h> #include <sys/mman.h> #include <unistd.h>diff --git a/drivers/event/dlb/pf/dlb_pf.c b/drivers/event/dlb/pf/dlb_pf.c index 2f7e30abbd..5445c2d57d 100644 --- a/drivers/event/dlb/pf/dlb_pf.c +++ b/drivers/event/dlb/pf/dlb_pf.c@@ -6,12 +6,13 @@ #include <stdbool.h> #include <stdio.h> #include <sys/mman.h> -#include <sys/fcntl.h> +#include <fcntl.h> #include <sys/time.h> #include <errno.h> #include <assert.h> #include <unistd.h> #include <string.h> + #include <rte_debug.h> #include <rte_log.h> #include <rte_dev.h>diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index b28ec58bfb..fb5ff012a4 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c@@ -11,7 +11,7 @@ #include <stdio.h> #include <string.h> #include <sys/mman.h> -#include <sys/fcntl.h> +#include <fcntl.h> #include <rte_common.h> #include <rte_config.h>diff --git a/drivers/event/dlb2/pf/dlb2_pf.c b/drivers/event/dlb2/pf/dlb2_pf.c index 1142da5b25..cfb22efe8a 100644 --- a/drivers/event/dlb2/pf/dlb2_pf.c +++ b/drivers/event/dlb2/pf/dlb2_pf.c@@ -6,12 +6,13 @@ #include <stdbool.h> #include <stdio.h> #include <sys/mman.h> -#include <sys/fcntl.h> +#include <fcntl.h> #include <sys/time.h> #include <errno.h> #include <assert.h> #include <unistd.h> #include <string.h> + #include <rte_debug.h> #include <rte_log.h> #include <rte_dev.h> --2.30.1
ack