Thread (130 messages) 130 messages, 16 authors, 2021-03-23

Re: [dpdk-dev] [PATCH v6 07/17] drivers: replace page size definitions with function

From: Andrew Boyer <hidden>
Date: 2021-03-01 14:22:12

On Feb 28, 2021, at 7:53 AM, Thomas Monjalon [off-list ref] wrote:

The page size is often retrieved from the macro PAGE_SIZE.
If PAGE_SIZE is not defined, it is either using hard coded default,
or getting the system value from the UNIX-only function sysconf().

Such definitions are replaced with the generic function
rte_mem_page_size() defined for each supported OS.

Removing PAGE_SIZE definitions will fix dlb drivers for musl libc,
because #ifdef checks were missing, causing redefinition errors.

Signed-off-by: Thomas Monjalon <redacted>
---
drivers/bus/pci/linux/pci_vfio.c        |  9 ++-------
drivers/bus/vmbus/linux/vmbus_uio.c     |  4 ++--
drivers/bus/vmbus/private.h             |  5 +----
drivers/bus/vmbus/rte_vmbus_reg.h       |  2 +-
drivers/bus/vmbus/vmbus_common_uio.c    |  4 ++--
drivers/crypto/virtio/virtio_pci.h      |  3 ++-
drivers/event/dlb/dlb.c                 |  7 +++++--
drivers/event/dlb/dlb_priv.h            |  2 --
drivers/event/dlb/pf/base/dlb_osdep.h   |  2 +-
drivers/event/dlb/pf/dlb_main.h         |  5 +----
drivers/event/dlb/pf/dlb_pf.c           | 10 ++++++----
drivers/event/dlb2/dlb2_priv.h          |  2 --
drivers/event/dlb2/pf/base/dlb2_osdep.h |  2 +-
drivers/event/dlb2/pf/dlb2_main.h       |  5 +----
drivers/event/dlb2/pf/dlb2_pf.c         |  8 ++++----
drivers/net/bnx2x/ecore_fw_defs.h       | 18 ++++++++++++------
drivers/net/ionic/ionic_lif.c           | 25 ++++++++++++++-----------
drivers/net/ionic/ionic_main.c          |  3 ++-
drivers/net/ionic/ionic_osdep.h         |  2 +-
drivers/net/netvsc/hn_rndis.c           | 12 ++++++------
drivers/net/netvsc/hn_rxtx.c            | 10 ++++++----
drivers/net/netvsc/hn_var.h             |  9 +++------
drivers/net/virtio/virtio.h             |  2 +-
drivers/net/virtio/virtio_ethdev.c      |  6 +++---
drivers/net/virtio/virtio_ethdev.h      |  4 ----
drivers/vdpa/ifc/ifcvf_vdpa.c           | 17 +++++++----------
26 files changed, 84 insertions(+), 94 deletions(-)
OK for net/ionic

Acked-by: Andrew Boyer <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help