On 22-Jan-21 12:15 PM, Burakov, Anatoly wrote:

On 21-Jan-21 5:21 PM, David Hunt wrote:

quoted

From: Bruce Richardson <redacted>

rename the public structs to have an rte_power_ prefix and
add them to version.map in experimental section.

Fixes: 210c383e247b ("power: packet format for vm power management")
Fixes: cd0d5547e873 ("power: vm communication channels in guest")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <redacted>
Signed-off-by: David Hunt <redacted>

---
changes in v4
* Improve sizeof's
* add the 2 functions to the version.map file
---

<snip>

quoted

diff --git a/lib/librte_power/rte_power_guest_channel.h 

b/lib/librte_power/rte_power_guest_channel.h
index c500c0cda..c9ab7bae8 100644

--- a/lib/librte_power/rte_power_guest_channel.h
+++ b/lib/librte_power/rte_power_guest_channel.h

@@ -11,7 +11,10 @@ extern "C" {

  #include <stdint.h>
  #include <stdbool.h>
-/* --- Incoming messages --- */
+#define MAX_VFS 10
+#define VM_MAX_NAME_SZ 32
+#define MAX_VCPU_PER_VM         8
+#define HOURS 24

These and other defines are in public header, and they're not under RTE_ 
namespace. To avoid clashes with user code, I would suggest either 
adding an RTE_ prefix, or maybe #undef'ing them at the end of the file.

Apologies, didn't realize this was in the next patch :D (also, #undef 
was a bad idea...)

-- 
Thanks,
Anatoly