Thread (69 messages) 69 messages, 6 authors, 2021-03-02

Re: [dpdk-dev] [PATCH v3 2/6] power: make channel msg functions public

From: Burakov, Anatoly <hidden>
Date: 2021-01-20 15:24:05

On 20-Jan-21 3:08 PM, David Hunt wrote:
On 20/1/2021 2:26 PM, Burakov, Anatoly wrote:
quoted
On 20-Jan-21 1:55 PM, David Hunt wrote:
quoted
From: Bruce Richardson <redacted>

Move the 2 public functions into rte_power_guest_channel.h

Fixes: 210c383e247b ("power: packet format for vm power management")
Fixes: cd0d5547e873 ("power: vm communication channels in guest")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <redacted>
Signed-off-by: David Hunt <redacted>

---
<snip>
quoted
  +/**
+ * Send a message contained in pkt over the Virtio-Serial to the 
host endpoint.
+ *
+ * @param pkt
+ *  Pointer to a populated struct channel_packet
+ *
+ * @param lcore_id
+ *  lcore_id.
Not very informative doxygen comment :)

Maybe "Use channel specific to this lcore_id"?
Something like that, yes. Or, "Use channel associated with this lcore ID".

-- 
Thanks,
Anatoly
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help