On 20-Jan-21 3:01 PM, David Hunt wrote:

On 20/1/2021 2:28 PM, Burakov, Anatoly wrote:

quoted

On 20-Jan-21 1:55 PM, David Hunt wrote:

quoted

From: Bruce Richardson <redacted>

Adjust meson.build so that 'ninja install' copies the new header
file into the installation directory.

Fixes: 210c383e247b ("power: packet format for vm power management")
Fixes: cd0d5547e873 ("power: vm communication channels in guest")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <redacted>
Signed-off-by: David Hunt <redacted>
---

IMO this should be part of the first patch, otherwise the build could 
(will?) be broken until this patch.

Hi Anatoly,

    It was broken before this patch set. I wanted to have everything in 
place, including the correct naming of structs/defines before allowing 
builds against the new header file, hence this order in the patch set.

Rgds,

Dave.

It's only my opinion obviously, but i rather prefer an approach of 
fixing build issues first, and then renaming everything, as I like to 
have each patch build at every step of the way. You probably know 
better, but from a cursory look, you should be able to keep 
progressively changing things but also keep everything building 
correctly every step of the way.

-- 
Thanks,
Anatoly