Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type
From: Thomas Monjalon <hidden>
Date: 2021-01-19 08:39:46
19/01/2021 08:56, Xueming(Steven) Li:
From: Andrew Rybchenko <redacted>quoted
On 1/19/21 10:37 AM, Xueming(Steven) Li wrote:quoted
From: Andrew Rybchenko <redacted>quoted
On 1/18/21 2:16 PM, Xueming Li wrote:quoted
+/** Ethernet device representor type */ enum +rte_eth_representor_type { + RTE_ETH_REPRESENTOR_NONE, /**< not a representor. */ + RTE_ETH_REPRESENTOR_VF, /**< representor of VF. */ + RTE_ETH_REPRESENTOR_SF, /**< representor of SF. */ + RTE_ETH_REPRESENTOR_PF, /**< representor of host PF. */RTE_ETH_REPRESENTOR_SF and PF looks dead in the patch. IMHO, addition of these members here make future patches which add support inconsistent.Yes, later patch in this patchset will support it.I know. The question is why it is not added in the later patches when these types are actually supported.Good suggestion, will update
+1 (I was sure it was already the case)