Re: [dpdk-dev] [PATCH v5 2/4] net/ipn3ke: delete MAC register address mask
From: Xu, Rosen <hidden>
Date: 2019-07-02 10:00:24
quoted hunk ↗ jump to hunk
-----Original Message----- From: Pei, Andy Sent: Monday, July 01, 2019 18:36 To: dev@dpdk.org Cc: Pei, Andy <redacted>; Xu, Rosen <redacted> Subject: [PATCH v5 2/4] net/ipn3ke: delete MAC register address mask original code is compatible with older device, whose mac register address is no more than 10 bits. Now we have mac register address longer than 10 bits, so we just delete the mask here. Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Cc: rosen.xu@intel.com Signed-off-by: Andy Pei <redacted> --- drivers/net/ipn3ke/ipn3ke_ethdev.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.cb/drivers/net/ipn3ke/ipn3ke_ethdev.c index 9079b57..8d3084d 100644--- a/drivers/net/ipn3ke/ipn3ke_ethdev.c +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c@@ -48,7 +48,6 @@ if (eth_group_sel != 0 && eth_group_sel != 1) return -1; - addr &= 0x3FF; target_addr = addr | dev_sel << 17; indirect_value = RCMD | target_addr << 32; @@ -86,7 +85,6 @@ if (eth_group_sel != 0 && eth_group_sel != 1) return -1; - addr &= 0x3FF; target_addr = addr | dev_sel << 17; indirect_value = WCMD | target_addr << 32 | wr_data; --1.8.3.1
Acked-by: Rosen Xu <redacted>