Thread (47 messages) 47 messages, 5 authors, 2019-07-09

Re: [dpdk-dev] [PATCH v2 2/4] net/ipn3ke: delete MAC register address mask

From: Xu, Rosen <hidden>
Date: 2019-06-12 01:17:31

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Pei, Andy
Sent: Tuesday, June 11, 2019 17:49
To: dev@dpdk.org
Cc: Pei, Andy <redacted>; Xu, Rosen <redacted>
Subject: [PATCH v2 2/4] net/ipn3ke: delete MAC register address mask

original code is compatible with older device, whose mac register address is
no more than 10 bits.
Now we have mac register address longer than 10 bits, so we just delete the
mask here.

Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
Cc: rosen.xu@intel.com

Signed-off-by: Andy Pei <redacted>
---
 drivers/net/ipn3ke/ipn3ke_ethdev.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c
b/drivers/net/ipn3ke/ipn3ke_ethdev.c
index 9079b57..8d3084d 100644
--- a/drivers/net/ipn3ke/ipn3ke_ethdev.c
+++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c
@@ -48,7 +48,6 @@
 	if (eth_group_sel != 0 && eth_group_sel != 1)
 		return -1;

-	addr &= 0x3FF;
 	target_addr = addr | dev_sel << 17;

 	indirect_value = RCMD | target_addr << 32; @@ -86,7 +85,6 @@
 	if (eth_group_sel != 0 && eth_group_sel != 1)
 		return -1;

-	addr &= 0x3FF;
 	target_addr = addr | dev_sel << 17;

 	indirect_value = WCMD | target_addr << 32 | wr_data;
--
1.8.3.1
Acked-by: Rosen Xu <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help