Re: [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters
From: Thomas Monjalon <hidden>
Date: 2018-03-30 15:40:41
I know that this patch is already applied, but I have some comments below. Please try to address them. 21/03/2018 15:27, Remy Horton:
+ /* If number of queues specified by application for both Rx and Tx is + * zero, use driver preferred values. This cannot be done individually + * as it is valid for either Tx or Rx (but not both) to be zero. + * If driver does not provide any preferred valued, fall back on + * EAL defaults. + */
The fallback could be set in rte_eth_dev_info_get() and call this function instead of calling directly dev_ops->dev_infos_get. It would require to never return -ENOTSUP. At least, some default values should be set in rte_eth_dev_info_get().
quoted hunk ↗ jump to hunk
@@ -1029,6 +1048,10 @@ struct rte_eth_dev_info { /** Configured number of rx/tx queues */ uint16_t nb_rx_queues; /**< Number of RX queues. */ uint16_t nb_tx_queues; /**< Number of TX queues. */ + + /** Tx/Rx parameter recommendations */ + struct rte_eth_dev_portconf default_rxportconf; + struct rte_eth_dev_portconf default_txportconf;
Some formatting comments: Usually, there is no blank line in structs. The doxygen comment must apply to each field. Have you checked what is the doxygen output?