Re: [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters
From: Shreyansh Jain <hidden>
Date: 2018-03-28 07:19:14
Hello Remy,
quoted hunk ↗ jump to hunk
-----Original Message----- From: Remy Horton [mailto:remy.horton@intel.com] Sent: Wednesday, March 21, 2018 7:58 PM To: dev@dpdk.org Cc: John McNamara <redacted>; Wenzhuo Lu [off-list ref]; Jingjing Wu [off-list ref]; Qi Zhang [off-list ref]; Beilei Xing [off-list ref]; Shreyansh Jain [off-list ref]; Thomas Monjalon [off-list ref] Subject: [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows testpmd to make use of per-PMD tuned parameter values. Signed-off-by: Remy Horton <redacted> --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4c0e258..82eb197 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c@@ -210,9 +210,10 @@ queueid_t nb_txq = 1; /**< Number of TX queues perport. */ /* * Configurable number of RX/TX ring descriptors. + * Defaults are supplied by drivers via ethdev. */ -#define RTE_TEST_RX_DESC_DEFAULT 1024 -#define RTE_TEST_TX_DESC_DEFAULT 1024 +#define RTE_TEST_RX_DESC_DEFAULT 0 +#define RTE_TEST_TX_DESC_DEFAULT 0 uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX descriptors. */ uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX descriptors. */
Can the change for burst size too be accommodated in this patch? I looked through them and they might not be as trivial as the change above - but if that is incorporated in this, it might serve as example for other applications. Or, I am also OK sending a separate patch for that change (maybe for iofwd case, at least) Either way: Acked-by: Shreyansh Jain <redacted>