Thread (91 messages) flat view 91 messages, 7 authors, 2017-04-14

Re: [PATCH v4 09/10] eal: make virtual bus use rte_vdev_device

From: Jan Blunck <hidden>
Date: 2017-03-27 07:43:04

On Mon, Mar 13, 2017 at 6:51 PM, Thomas Monjalon
[off-list ref] wrote:
2017-03-06 11:56, Jan Blunck:
quoted
This allows the virtual bus to be rescanned and probed by tracking the
creation of rte_vdev_device.

Signed-off-by: Jan Blunck <redacted>
Tested-by: Ferruh Yigit <redacted>
Acked-by: Shreyansh Jain <redacted>
There are a lot of strcmp in this patch.
Are you sure that you are referring to this patch? There is a single
strcmp added here in the find_vdev() helper.
Maybe it should be abstracted in a "match" function.
It would allow bringing new vdev rules in future.
Technically that is possible. If I remember correctly we agreed that
matching based on the alias is scheduled for removal in a future
release. Therefore I believe it is better to keep this in the virtual
bus layer implementation instead of moving it down to the PMDs by
introducing a driver specific "match" function.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help