Re: [PATCH 6/7] eal: add struct rte_vdev_device

On Wed, Feb 15, 2017 at 6:11 PM, Ferruh Yigit [off-list ref] wrote:

On 2/15/2017 10:02 AM, Jan Blunck wrote:

quoted

This adds the rte_vdev_device structure which embeds a generic rte_device.

Signed-off-by: Jan Blunck <redacted>

<...>

quoted

+struct rte_vdev_device {
+     TAILQ_ENTRY(rte_vdev_device) next;      /**< Next attached vdev */
+     struct rte_device device;               /**< Inherit core device */

What do you think adding a name field here ?

"dev->device.devargs->virt.drv_name" used a few times, since probing
virtual devices done based on name.

This is device name, and accessing it via "devargs->virt.drv_name" is
not that clear. It is possible to create a name field here, set it
during probe or init to point devargs field and use it wherever
required, does it make sense?

Why don't we add such a thing to the generic rte_device instead? While
we are at it we might want to also add a driver private data field.

Thoughts?