On 1/18/2017 5:49 PM, Ferruh Yigit wrote:
<...>

quoted

quoted

quoted

quoted

quoted

quoted

OK for these definitions, however API documentation
(doc/guides/prog_guide/rte_flow.rst) must be kept up to date, and it
would be great if testpmd support for these new items was added
simultaneously (changes in app/test-pmd/cmdline.c,
app/test-pmd/cmdline_flow.c and

doc/guides/testpmd_app_ug/testpmd_funcs.rst).

quoted

How about putting all rte_flow changes (API & testpmd) in their own
separate patch?

I thought it can be more useful to have library and its user updated
in same patch, gives more context. But missed rte_flow documentation ...

quoted

You could use VLAN PCP/DEI/VID definitions as an example to expose
partial bit-fields (e.g. epcp_edei_in_ecid_b) in testpmd, see:

 1419fd5a6c9f ("app/testpmd: add protocol fields to flow command")

Now if re-spinning this series yet again is too much work, you can
go ahead with this commit as long as you do not forget to submit the
rest later, thanks.

Is following todo list complete:
1- update rte_flow document, doc/guides/prog_guide/rte_flow.rst,
document two new item types: E_TAG & NVGRE.

2- Add testpmd sample implementation and documentation.

I am sorry for miss rte_flow.rst document update, I DON'T know there is

such a new file of rte_flow.rst.

quoted

And also these two types of E_TAG & NVGRE are added into code after
rte_flow patch, So testpmd  implementation do not support for these type.
Now, we have been work on task of 17.05.
How about finish (1) first as one patch, then after busy work of 17.05  to

add (2) as another patch?

quoted

OR, if these two work merge in to patch set,   I will may be begin to do after

the 17.05  task finish?

quoted

Which one is OK for you?

Changes can be in two separate patches, and if possible, can this get priority
against 17.05 task?
This is for 17.02 feature and not completely finished, missing for last touches..

Thanks,
ferruh

quoted

Thank you.

quoted

Hi Wei,

Would you mind working on a patch to cover above items?

Thanks,
ferruh

Add testpmd implementation example is not in our plan from the begin of the task generic filter API by us,
Because all this part is not covered by us(intel) when task allocation.

Right, sample testpmd implementation is not directly related to the
adding rte_flow support to the driver.

But for this, a rte_flow library update required, and sample testpmd
implementation is part of rte_flow update.

quoted

BUT if this component  is need by community, I will report to my leader and add it into our next work plan and try to finish it ASAP.

Yes please, I believe it is needed.

Is there any update from this work?

Thanks,
ferruh

quoted

Thank you.